[PATCH] D140727: [XRay] Add initial support for loongarch64

[Limin Zhang via Phabricator via cfe-commits]

Ami-zhang added inline comments.


================
Comment at: compiler-rt/lib/xray/xray_loongarch64.cpp:30
+// are 2RI12-type and 2RI16-type.
+inline static uint32_t
+encodeInstruction2RIx(uint32_t Opcode, uint32_t Rd, uint32_t Rj,
----------------
MaskRay wrote:
> Early xray code unfortunately does not respect the conventional style that well.
> The usual order is `static inline`
Done, adjusted to `static inline`.


================
Comment at: compiler-rt/lib/xray/xray_trampoline_loongarch64.S:20
+  .type __xray_FunctionEntry, at function
+__xray_FunctionEntry:
+  .cfi_startproc
----------------
MaskRay wrote:
> The symbol needs to be hidden and consider using some macros. See xray_trampoline_AArch64.S
> 
Ok, I have modified them.
Thanks for your suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140727/new/

https://reviews.llvm.org/D140727