[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

Christian Walther via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 12 02:21:56 PDT 2023


cwalther added a comment.

I am unable to provoke any problem with my tests by putting various things in `/usr/lib/gcc/`, and I also can’t find any code that would go looking there on the code path that is exercised by these tests. Can you give me a hint where that code is, so I can try harder to provoke it? Is it outside of `Generic_GCC::GCCInstallationDetector`? `GCCInstallationDetector` is not used on the code path taken for `--target=powerpc[64][le]-unknown-eabi` (after my patch), as far as I can tell. It’s only used by `Generic_GCC` and subclasses, getting away from which is the whole point of my patch.

Or are you suggesting the addition of --sysroot just to prevent potential future problems?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154357/new/

https://reviews.llvm.org/D154357



More information about the cfe-commits mailing list