[clang] b10899d - [clang] Fix -Wlogical-op-parentheses in Clang.cpp (NFC)
Jie Fu via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 11 16:54:27 PDT 2023
Author: Jie Fu
Date: 2023-07-12T07:53:50+08:00
New Revision: b10899d869954e1426684cbc20a43d7303075d49
URL: https://github.com/llvm/llvm-project/commit/b10899d869954e1426684cbc20a43d7303075d49
DIFF: https://github.com/llvm/llvm-project/commit/b10899d869954e1426684cbc20a43d7303075d49.diff
LOG: [clang] Fix -Wlogical-op-parentheses in Clang.cpp (NFC)
/Users/jiefu/llvm-project/clang/lib/Driver/ToolChains/Clang.cpp:7345:56: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
(WholeProgramVTables || SanitizeArgs.needsLTO()) &&
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
/Users/jiefu/llvm-project/clang/lib/Driver/ToolChains/Clang.cpp:7345:56: note: place parentheses around the '&&' expression to silence this warning
(WholeProgramVTables || SanitizeArgs.needsLTO()) &&
^
(
1 error generated.
Added:
Modified:
clang/lib/Driver/ToolChains/Clang.cpp
Removed:
################################################################################
diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp
index 796c60f0739285..bf09fc859a16df 100644
--- a/clang/lib/Driver/ToolChains/Clang.cpp
+++ b/clang/lib/Driver/ToolChains/Clang.cpp
@@ -7342,8 +7342,8 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
}
bool DefaultsSplitLTOUnit =
- (WholeProgramVTables || SanitizeArgs.needsLTO()) &&
- (LTOMode == LTOK_Full || TC.canSplitThinLTOUnit()) ||
+ ((WholeProgramVTables || SanitizeArgs.needsLTO()) &&
+ (LTOMode == LTOK_Full || TC.canSplitThinLTOUnit())) ||
(!Triple.isPS4() && UnifiedLTO);
bool SplitLTOUnit =
Args.hasFlag(options::OPT_fsplit_lto_unit,
More information about the cfe-commits
mailing list