[PATCH] D154786: [Clang][Driver] Pass through the --be8 endian flag to linker in BareMetal driver For Arm.

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 11 09:40:13 PDT 2023


MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:40
+bool arm::isArmBigEndian(const llvm::Triple &Triple, const ArgList &Args) {
+  bool IsBigEndian = false;
+
----------------
We do not need this variable. After an early return, we can just `return Triple.getArch() == llvm::Triple::armeb || ...`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154786/new/

https://reviews.llvm.org/D154786



More information about the cfe-commits mailing list