[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 11 09:10:33 PDT 2023


ChuanqiXu added a comment.

In D41416#4488517 <https://reviews.llvm.org/D41416#4488517>, @Hahnfeld wrote:

> In D41416#4487516 <https://reviews.llvm.org/D41416#4487516>, @ChuanqiXu wrote:
>
>> But some local in tree tests got failed. I took some time to investigate them but I didn't get insights :  (
>
> If the failures involve template template parameters, please note that you need https://reviews.llvm.org/D153003 for that to properly hash and find in the list of lazy specializations.

Got it. This is on my TODO list. (Feel free to take it if you're hurry. Just tell me when you started. So that we can avoid reinventing the same wheel)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D41416/new/

https://reviews.llvm.org/D41416



More information about the cfe-commits mailing list