[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

Jonas Hahnfeld via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 11 08:53:34 PDT 2023


Hahnfeld added inline comments.


================
Comment at: clang/include/clang/AST/DeclTemplate.h:786-788
+    uint32_t DeclID = ~0U;
+    unsigned ODRHash = ~0U;
+    bool IsPartial = false;
----------------
ChuanqiXu wrote:
> Maybe this can save some space.
Can you elaborate why this would save space? The best practice is to order data members by size to avoid padding gaps. As far as I can see, this is already done here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D41416/new/

https://reviews.llvm.org/D41416



More information about the cfe-commits mailing list