[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

Dmitry Polukhin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 11 08:48:04 PDT 2023


DmitryPolukhin added a comment.

In D154602#4483600 <https://reviews.llvm.org/D154602#4483600>, @MaskRay wrote:

> Thanks for the patch! But I share the concern that the test is added to a wrong layer (https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-at-the-wrong-layer).
>
> We can add a `clang::createInvocation` test to `clang/unittests/Driver/ToolChainTest.cpp`.

Thank you for the suggestion. Done, please take another look.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154602/new/

https://reviews.llvm.org/D154602



More information about the cfe-commits mailing list