[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 11 06:04:21 PDT 2023


aaron.ballman added a comment.

This seems reasonable to me, but I do wonder if changing the return type from int to bool will cause surprises for anyone. I see why it's done, but this seems more like a C interface (to me) which would return an `int`; returning a `bool` gets promoted to `int` when you sneeze near it, so I wonder about performance implications. But at the same time, we wouldn't want a vector of ints returns in the vector case, I would suspect.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153339/new/

https://reviews.llvm.org/D153339



More information about the cfe-commits mailing list