[PATCH] D154950: [include-cleaner] Fix the `fixIncludes` API not respect main-file header.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 11 05:56:36 PDT 2023


hokein added inline comments.


================
Comment at: clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp:303
 
-  EXPECT_EQ(fixIncludes(Results, Code, format::getLLVMStyle()), R"cpp(
+  EXPECT_EQ(fixIncludes(Results, "d.cc", Code, format::getLLVMStyle()),
+R"cpp(#include "d.h"
----------------
kadircet wrote:
> can you also have a test in which we insert "d.h" and it gets put into the right place?
added a test with a FIXME -- unfortunately, this case doesn't work yet (I believe this is a bug in the `tooling::HeaderIncludes`, I plan to fix it afterwards.)




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154950/new/

https://reviews.llvm.org/D154950



More information about the cfe-commits mailing list