[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

Yurong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 11 04:08:33 PDT 2023


yronglin added a comment.

In D154784#4486721 <https://reviews.llvm.org/D154784#4486721>, @rjmccall wrote:

> We had that discussion in the bug report.  Let's just increase the widths unconditionally; this is not such a common expression class that we need to worry about using an extra word.

Thanks for your review!

> Let's just increase the widths unconditionally

Do you mean:

  class PseudoObjectExprBitfields {
      friend class ASTStmtReader; // deserialization
      friend class PseudoObjectExpr;
  
      unsigned : NumExprBits;
      unsigned NumSubExprs : 16;
      unsigned ResultIndex : 16;
    };


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154784/new/

https://reviews.llvm.org/D154784



More information about the cfe-commits mailing list