[PATCH] D154709: [clang][ASTImporter] Add a 'Message' member to ASTImportError and use it throughout ASTImporter

[Balázs Kéri via Phabricator via cfe-commits]

balazske added a comment.

The goal is to have a message always in `ASTImportError`? Then probably the constructor without message can be removed, at least to check if really the message is added at all places. I found that it is missing in `VisitObjCImplementationDecl`.
I do not know what happens with messages passed to `FromDiag` or `ToDiag` and if these are available somehow to LLDB. Otherwise it would be even better to remove all FromDiag and ToDiag messages from `ASTImporter` and put these messages into `ASTImportError` and use later in the way that is needed by the use case. This would require to pass a message to `HandleNameConflict` but then we have always the detailed message. There are places where diagnostic is generated but there is no error, we should check if this is correct and if we can remove the diagnostic or make import error.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154709/new/

https://reviews.llvm.org/D154709