[PATCH] D154905: [clang] Implement `PointerLikeTraits` for `{File,Directory}EntryRef`

Ben Langmuir via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 10 16:17:08 PDT 2023


benlangmuir added inline comments.


================
Comment at: clang/include/clang/Basic/DirectoryEntry.h:211
+
+  static constexpr int NumLowBitsAvailable = 3;
+};
----------------
I suggest not hard-coding it if you can get away with it; maybe `PointerLikeTypeTraits<clang::DirectoryEntryRef::MapEntry *>::NumLowBitsAvailable`? I think 3 could be wrong on a 32-bit platform for example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154905/new/

https://reviews.llvm.org/D154905



More information about the cfe-commits mailing list