[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 10 13:30:09 PDT 2023


tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:1294
+    if (!LangOpts.HIP)
+      Builder.defineMacro("__CLANG_CUDA_APPROX_TRANSCENDENTALS__");
+    Builder.defineMacro("__CLANG_GPU_APPROX_TRANSCENDENTALS__");
----------------
I think we can remove it. I don't think we need to keep the old one around. Internal headers have been changed and the macro was never intended for public use. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154797/new/

https://reviews.llvm.org/D154797



More information about the cfe-commits mailing list