[PATCH] D154773: [AST] Use correct APSInt width when evaluating string literals

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 10 08:39:55 PDT 2023


aaron.ballman accepted this revision.
aaron.ballman added a comment.

I think this is a good NFC change as it brings us one TINY step closer towards supporting platforms where `CHAR_BIT != 8`. But I agree with Corentin that a lot more work needs to happen to support that kind of target; restarting the discussion on the linked RFC would be a good idea if you plan to aim for full support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154773/new/

https://reviews.llvm.org/D154773



More information about the cfe-commits mailing list