[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 10 06:38:49 PDT 2023


jhuber6 added a comment.

In D153725#4485039 <https://reviews.llvm.org/D153725#4485039>, @arsenm wrote:

> And the libomptarget build is in fact doing that, but it shouldn't have to. What it's doing actually seems really unreasonable. It's only building the locally found targets when it should be building all targetable devices. The inconvenience there is that's too many devices, so as a build time hack you should be able to opt-in to a restricted subset. Even better would be if we would only build a copy for a reasonable subset of targets (i.e. one per generation where there's actually some semblance of compatibility). Or could just capitulate and rely on the hacks device libs does

The `libomptarget` build uses it to determine if it should build the tests mostly, we don't want to configure tests for a system that cannot support them. The `libc` tests however requires it to set the architecture for its test configuration since we can't support multiple test architectures at the same time, it required too much work so I shelved that. We more or less just say "If you've got HSA / CUDA we expect to run tests".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153725/new/

https://reviews.llvm.org/D153725



More information about the cfe-commits mailing list