[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added a comment.

In D153725#4484973 <https://reviews.llvm.org/D153725#4484973>, @arsenm wrote:

> In D153725#4484754 <https://reviews.llvm.org/D153725#4484754>, @JonChesterfield wrote:
>
>> The problem with using the proper API via HSA or similar is twofold:
>>
>> - we use this tool to enable tests, which means HSA has to exist before building clang or the tests don't run and HSA now requires clang to build
>
> I don't follow this. You don't need this to work to perform the build and test build. You may need it to execute the tests, but if HSA doesn't exist they won't be able to run anyway. If a build is invoking these tools at cmake time it's just broken

And the libomptarget build is in fact doing that, but it shouldn't have to. What it's doing actually seems really unreasonable. It's only building the locally found targets when it should be building all targetable devices. The inconvenience there is that's too many devices, so as a build time hack you should be able to opt-in to a restricted subset. Even better would be if we would only build a copy for a reasonable subset of targets (i.e. one per generation where there's actually some semblance of compatibility). Or could just capitulate and rely on the hacks device libs does


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153725/new/

https://reviews.llvm.org/D153725