[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

Mon Jul 10 06:11:13 PDT 2023

arsenm added a comment.

In D153725#4484754 <https://reviews.llvm.org/D153725#4484754>, @JonChesterfield wrote:

> The problem with using the proper API via HSA or similar is twofold:
>
> - we use this tool to enable tests, which means HSA has to exist before building clang or the tests don't run and HSA now requires clang to build

I don't follow this. You don't need this to work to perform the build and test build. You may need it to execute the tests, but if HSA doesn't exist they won't be able to run anyway. If a build is invoking these tools at cmake time it's just broken

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153725/new/

https://reviews.llvm.org/D153725