[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added inline comments.


================
Comment at: clang/tools/amdgpu-arch/AMDGPUArchByHIP.cpp:80
+    if (err != hipSuccess) {
+      llvm::errs() << "Failed to get device id for ordinal " << i << "\n";
+      return 1;
----------------
yaxunl wrote:
> arsenm wrote:
> > single quotes around '\n'
> will do
Should print some kind of stringified error codes for all of these


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153725/new/

https://reviews.llvm.org/D153725