[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

Mon Jul 10 02:10:17 PDT 2023

donat.nagy accepted this revision.
donat.nagy added a comment.
This revision is now accepted and ready to land.

Ok, then I think you can finally merge this commit and its two predecessors. I'm happy to see that this improvement is complete.

I hope that you can later add a special case for the standard streams, but I agree that it should be a separate commit.

Thanks for clarifying the `ftell` situation, that's clearly an engine issue that should not block this checker improvement. However, I'd be really glad to see a cleanup of the interestingness system (as a separate project), because its inconsistency leads to lots of very confusing bug reports.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154423/new/

https://reviews.llvm.org/D154423