[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

[Fako via Phabricator via cfe-commits]

Fako432 added a comment.
Herald added a subscriber: wangpc.

In D128059#3640564 <https://reviews.llvm.org/D128059#3640564>, @cor3ntin wrote:

> In D128059#3640544 <https://reviews.llvm.org/D128059#3640544>, @hubert.reinterpretcast wrote:
>
>> In D128059#3640424 <https://reviews.llvm.org/D128059#3640424>, @cor3ntin wrote:
>>
>>> @aaron.ballman Thanks for the review. I landed the changes and got a bunch of bots screaming at me for changes that are completely unrelated
>>>
>>> https://lab.llvm.org/buildbot/#/builders/21/builds/45146
>>> https://lab.llvm.org/buildbot/#/builders/36/builds/22838
>>> https://lab.llvm.org/buildbot/#/builders/121/builds/21183/monkey mart <https://monkeymart.online/>
>>
>> What do you mean it is completely unrelated? You have `__ALTIVEC__`-specific changes and it knocks out the PPC bots.
>
> Good point. The error was a bit misleading but i guess what's happening is a segfault when running `clang-ast-dump`. 
> I'm reverting for now and I don't really know how to go from there as I don't have the hardware to test that code path.

You raise a valid argument. The confusion caused by the error could potentially be attributed to a segmentation fault occurring during the execution.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128059/new/

https://reviews.llvm.org/D128059