[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

[Michael Maitland via Phabricator via cfe-commits]

michaelmaitland added inline comments.


================
Comment at: clang/include/clang/Basic/riscv_vector.td:2381
+  if HasVV then {
+    defvar suffix = !if(!or(HasVS, !eq(NAME, "vsm4r")), "vv", "v");
+    // We don't need suffix in Zvkb extension since it's consider as normal
----------------
Why do we check `HasVS` when assigning suffix `vv`? I would have expected we use `HasVV`. In addition, why do we need to check `!eq(NAME, "vsm4r")` instead of setting the `HasVV` for that instruction?


================
Comment at: clang/include/clang/Basic/riscv_vector.td:2400
+    // mnemonics into its intrinsic function name.
+    defvar suffix = !if(!eq(NAME, "vgmul"), "vv", "vs");
+    defvar name = NAME # !if(!or(IsZvkb, !or(!eq(NAME, "vaesz"),
----------------
Why not set `HasVS=1` and `HasVV=0` for `vaesz` instead of checking `!if(!eq(NAME, "vgmul"),...`?

Also, do you mean to be discussing `vaesz` in the comment but use `vgmul` below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138810/new/

https://reviews.llvm.org/D138810