[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jul 9 11:49:00 PDT 2023
MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.
Thanks for the patch! But I share the concern that the test is added to a wrong layer (https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-at-the-wrong-layer).
We can add a `clang::createInvocation` test to `clang/unittests/Driver/ToolChainTest.cpp`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154602/new/
https://reviews.llvm.org/D154602
More information about the cfe-commits
mailing list