[PATCH] D134544: [clang-cl] Implement /ZH: flag

[Nico Weber via Phabricator via cfe-commits]

thakis added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:3220
       Values<"simple,mangled">, Flags<[CC1Option, NoDriverOption]>;
+def gsrc_hash_EQ : Joined<["-"], "gsrc-hash=">,
+  Group<g_flags_Group>, Flags<[CC1Option, NoDriverOption]>,
----------------
dblaikie wrote:
> This is a driver flag, yeah? Might be worth documenting/emitting a warning that it's not compatible with DWARF emission? (looks like the DWARF code in LLVM ignores any hash that's not MD5, because DWARF doesn't have a way to encode other hash algorithms currently - though maybe there's some extension space available to add it, I haven't checked/looked)
belated: this is `Flags<[CC1Option, NoDriverOption]>,` in the line below, so I think this isn't a driver flag. (It's what the CLFlags added below expand to – those are driver flags, but only for clang-cl.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134544/new/

https://reviews.llvm.org/D134544