[PATCH] D139629: clang: Stop emitting "strictfp"

Zahira Ammarguellat via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 7 11:10:11 PDT 2023


zahiraam added a comment.

In D139629#4481408 <https://reviews.llvm.org/D139629#4481408>, @rjmccall wrote:

> In D139629#4481030 <https://reviews.llvm.org/D139629#4481030>, @zahiraam wrote:
>
>> According to this comment https://reviews.llvm.org/D87528#2342132, it looks like @rjmccall had proposed the addition of the attribute. @rjmccall Do you recall why it was added?
>
> My suggestion was that we track the pragma in the Clang AST with an attribute instead of a bit on the Decl.  I have no idea why IR generation is adding both a string attribute and the builtin attribute to the IR function, but if doesn't have any obvious effect, I suggest just removing it.

Thanks for your response. I second removing it then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139629/new/

https://reviews.llvm.org/D139629



More information about the cfe-commits mailing list