[PATCH] D154543: [llvm] Move StringExtras.h include from Error.h to Error.cpp

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 7 10:14:57 PDT 2023


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

I have spot checked a few files and the additional #include looks great!
As mentioned in the other patch, it would be better landing the #include adjustment part separately so that the `llvm/Support/Error.h` change is more focused.
Also, there is lower risk if something breaks, either you or someone else reverts the patch, and causes unneeded churn to many files.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154543/new/

https://reviews.llvm.org/D154543



More information about the cfe-commits mailing list