[PATCH] D154123: [HIP] Start document HIP support by clang

Siu Chi Chan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 7 09:50:49 PDT 2023


scchan added inline comments.


================
Comment at: clang/docs/HIPSupport.rst:82
+===========================
+
+1. **Compiler Options**: If you specify paths using the compiler options, these will override the correponding paths set via environment variables. 
----------------
I think it would be easier to understand by explicitly calling out the order of precedence:

- For HIP path:
      - --hip-path option
      - HIP_PATH env var
      - --rocm-path option
     - ROCM_PATH env var
     - default automatic detection


-- For device lib:
      - --hip-device-lib-path option
      - HIP_DEVICE_LIB_PATH env var
      - --rocm-path option
      -  ROCM_PATH env var
      - default automatic detection



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154123/new/

https://reviews.llvm.org/D154123



More information about the cfe-commits mailing list