[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

[Joseph Huber via Phabricator via cfe-commits]

jhuber6 added inline comments.


================
Comment at: clang/tools/amdgpu-arch/AMDGPUArch.cpp:50
+#else
+  return printGPUsByHSA();
+#endif
----------------
arsenm wrote:
> The HIP path should work on linux too. I generally think we should build as much code as possible on all hosts, so how about
> ```
> #ifndef _WIN32
>   if (tryHSA())
>     return 0;
> #endif
> 
> tryHIP()
> ```
> 
> 
> 
That'd be fine, I'm in favor of sticking to HSA since it's a smaller runtime that's more reasonable to build standalone without the whole ROCm stack.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153725/new/

https://reviews.llvm.org/D153725