[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

Fri Jul 7 04:14:05 PDT 2023

hokein added a comment.

In D153296#4480141 <https://reviews.llvm.org/D153296#4480141>, @yronglin wrote:

> In D153296#4479718 <https://reviews.llvm.org/D153296#4479718>, @hokein wrote:
>
>> Thanks, this looks good.
>
> Thanks for your review! I don't know why the reversion status still `Needs Review`, and the `libcxx ci` often fails to start.

I guess the `Needs Review` is probably caused by the previous "Requested Changes" by Aaron.
The `libcxx ci` failure doesn't seem to be relevant. I think we're all on the same page about the fix, it is fine to land it assuming that the `ninja check-clang` passes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153296/new/

https://reviews.llvm.org/D153296