[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

[Mariya Podchishchaeva via Phabricator via cfe-commits]

Fznamznon added inline comments.


================
Comment at: clang/lib/AST/Expr.cpp:1760
 
+  // FIXME: remove remaining dependence computation to computeDependence().
+  auto Deps = E->getDependence();
----------------
cor3ntin wrote:
> Maybe we should do that now, by passing `TemplateArgs` to computeDependence?
> 
> Otherwise there is a good chance that fixme never gets fixed !
`computeDependence` is called by the constructor of `MemberExpr` which doesn't accept template augments. In order to do that, I would need to modify the constructor of `MemberExpr`.
Is it still reasonable to do as a part of this fix?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154689/new/

https://reviews.llvm.org/D154689