[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence
Mariya Podchishchaeva via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 7 01:55:49 PDT 2023
Fznamznon added inline comments.
================
Comment at: clang/lib/AST/ComputeDependence.cpp:625
auto D = E->getBase()->getDependence();
+ D |= getDependenceInExpr(E->getMemberNameInfo());
+
----------------
While implementing this patch I was following Richard's guide from https://github.com/llvm/llvm-project/issues/48731#issuecomment-1529150797 . The problem is, I didn't manage to write a test that would fail due to clang not taking into account `NameInfo` dependence. Turns out in most cases where it can be dependent either Base itself is dependent or CXXPseudoDestructorExpr/CXXDependentScopeMemberExpr is created inside the template function.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154689/new/
https://reviews.llvm.org/D154689
More information about the cfe-commits
mailing list