[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

Nuno Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 6 15:04:31 PDT 2023


nlopes added inline comments.


================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1541
+    CGF.Builder.CreateBr(CastFail);
+    return llvm::UndefValue::get(CGF.VoidPtrTy);
+  }
----------------
Please use PoisonValue as a placeholder whenever possible. We are trying to get rid of undef.
Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154658/new/

https://reviews.llvm.org/D154658



More information about the cfe-commits mailing list