[PATCH] D154493: [X86] Support some Intel CPUs for cpu_specific/dispatch feature

[Simon Pilgrim via Phabricator via cfe-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:333
   { {"pentium"}, CK_Pentium, ~0U, FeatureX87 | FeatureCMPXCHG8B, 'B', false },
   { {"pentium-mmx"}, CK_PentiumMMX, ~0U, FeaturesPentiumMMX, '\0', false },
   { {"pentium_mmx"}, CK_PentiumMMX, ~0U, FeaturesPentiumMMX, 'D', true },
----------------
FreddyYe wrote:
> RKSimon wrote:
> > add this as well?
> cpu names contain '-' are not supported for cpu_specific/dispatch feature since '-' is not an identifier character. The solution here is creating a new name with '_' replacing and set the OnlyForCPUDispatchSpecific as `true`, like `icelake-client`, `icelake-server` and `goldmont-plus`
Understood - cheers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154493/new/

https://reviews.llvm.org/D154493