[PATCH] D154597: [clang][dataflow] Various refactorings to UncheckedOptionalAccessModel.

[Martin Böhme via Phabricator via cfe-commits]

mboehme added inline comments.


================
Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:258
 /// symbolic value of its "has_value" property.
-StructValue &createOptionalValue(Environment &Env, BoolValue &HasValueVal) {
+StructValue &createOptionalValue(BoolValue &HasValueVal, Environment &Env) {
   auto &OptionalVal = Env.create<StructValue>();
----------------
Moved `Env` parameter to the end for consistency with the newly added overload (below); `Env` is just a "context" parameter, `HasValueVal` is the more important parameter and should therefore come first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154597/new/

https://reviews.llvm.org/D154597