[PATCH] D153340: [include-cleaner] Add an IgnoreHeaders flag to the command-line tool.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 6 02:18:09 PDT 2023


hokein added inline comments.


================
Comment at: clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp:231
+  }
+  return [FilterRegs](llvm::StringRef Path) {
+    llvm::errs() << "Path: " << Path << "\n";
----------------
kadircet wrote:
> `FilterRegs=std::move(FilterRegs)` and drop the `shared_ptr`?
This was my first attempt, it didn't work, we're returning a lamdba function, which invokes a delete constructor of `llvm::Regex`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153340/new/

https://reviews.llvm.org/D153340



More information about the cfe-commits mailing list