[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

Sunil K via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 5 23:41:43 PDT 2023


koops added inline comments.


================
Comment at: clang/include/clang/Sema/Sema.h:11094
 
+  bool checkLastPrivateForMappedDirectives(ArrayRef<OMPClause *> Clauses);
+  bool mapLoopConstruct(llvm::SmallVector<OMPClause *, 8> *ClausesWithoutBind,
----------------
ABataev wrote:
> const member function?
> Add a comment
"checkLastPrivateForMappedDirectives" is calling a non-const function "checkGenericLoopLastprivate". Since, this is a pre-existing function and is being called from other locations, I cannot make "checkLastPrivateForMappedDirectives" a const.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144634/new/

https://reviews.llvm.org/D144634



More information about the cfe-commits mailing list