[PATCH] D154396: [clang] Add support for SerenityOS

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 5 14:24:37 PDT 2023


phosek added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Serenity.h:38
+
+class LLVM_LIBRARY_VISIBILITY Serenity : public ToolChain {
+public:
----------------
Have you considered inheriting from `Generic_GCC` to allow more code reuse?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154396/new/

https://reviews.llvm.org/D154396



More information about the cfe-commits mailing list