[PATCH] D154477: [include-cleaner] Ignore the layering-violation errors for the standalone tool

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 5 01:56:28 PDT 2023


kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp:99
+  bool BeginInvocation(CompilerInstance &CI) override {
+    // Disable the clang-module-based layering-violation checks.
+    // These checks emit errors for a compilable source code. We want the tool
----------------
maybe mention the general stance against diagnostics here?

```
We only want to perform include-cleaner analysis. So we disable diagnostics that won't affect our analysis to make the tool more robust against in-development code.

```

and then follow up with specific around disabling decluse


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154477/new/

https://reviews.llvm.org/D154477



More information about the cfe-commits mailing list