[PATCH] D154460: [ODRHash] Stop hashing `ObjCMethodDecl::isPropertyAccessor` as it doesn't capture inherent method quality.

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai created this revision.
vsapsai added reviewers: ChuanqiXu, jansvoboda11, Bigcheese.
Herald added a subscriber: ributzka.
Herald added a project: All.
vsapsai requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

`isPropertyAccessor` depends on the surrounding code and not on the method
itself. That's why it can be different in different modules. And
mismatches shouldn't be an error.

rdar://109481753


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154460

Files:
  clang/lib/AST/ODRHash.cpp
  clang/test/Modules/compare-objc-nonisolated-methods.m


Index: clang/test/Modules/compare-objc-nonisolated-methods.m
===================================================================
--- clang/test/Modules/compare-objc-nonisolated-methods.m
+++ clang/test/Modules/compare-objc-nonisolated-methods.m
@@ -5,12 +5,17 @@
 // is not an error because it depends on the surrounding code and not on the method itself.
 // RUN: %clang_cc1 -fsyntax-only -verify -I%t/include -fmodules -fimplicit-module-maps -fmodules-cache-path=%t/modules.cache -fmodule-name=Override %t/test-overriding.m
 
+// Test that different values of `ObjCMethodDecl::isPropertyAccessor` in different modules
+// is not an error because it depends on the surrounding code and not on the method itself.
+// RUN: %clang_cc1 -fsyntax-only -verify -I%t/include -fmodules -fimplicit-module-maps -fmodules-cache-path=%t/modules.cache -fmodule-name=PropertyAccessor %t/test-property_accessor.m
+
 //--- include/Common.h
 @interface NSObject
 @end
 
 //--- include/Indirection.h
 #import <Override.h>
+#import <PropertyAccessor.h>
 
 //--- include/module.modulemap
 module Common {
@@ -25,6 +30,10 @@
   header "Override.h"
   export *
 }
+module PropertyAccessor {
+  header "PropertyAccessor.h"
+  export *
+}
 
 //--- include/Override.h
 #import <Common.h>
@@ -52,3 +61,31 @@
 void triggerOverrideCheck(SubClass *sc) {
   [sc potentialOverride];
 }
+
+//--- include/PropertyAccessor.h
+#import <Common.h>
+ at interface PropertySubClass: NSObject
+- (int)potentialProperty;
+- (void)setPotentialProperty:(int)p;
+ at end
+
+//--- PropertyAccessor_Internal.h
+#import <PropertyAccessor.h>
+ at interface PropertySubClass()
+ at property int potentialProperty;
+ at end
+
+//--- test-property_accessor.m
+//expected-no-diagnostics
+// Get a version of `PropertySubClass` where `-[PropertySubClass potentialProperty]`
+// is a property accessor.
+#import "PropertyAccessor_Internal.h"
+
+// Get a version of `PropertySubClass` where `-[PropertySubClass potentialProperty]`
+// is not a property accessor because module "PropertyAccessor" doesn't know about PropertyAccessor_Internal.h.
+#import <Indirection.h>
+
+void triggerPropertyAccessorCheck(PropertySubClass *x) {
+  int tmp = [x potentialProperty];
+  [x setPotentialProperty: tmp];
+}
Index: clang/lib/AST/ODRHash.cpp
===================================================================
--- clang/lib/AST/ODRHash.cpp
+++ clang/lib/AST/ODRHash.cpp
@@ -373,7 +373,6 @@
   void VisitObjCMethodDecl(const ObjCMethodDecl *Method) {
     ID.AddInteger(Method->getDeclKind());
     Hash.AddBoolean(Method->isInstanceMethod()); // false if class method
-    Hash.AddBoolean(Method->isPropertyAccessor());
     Hash.AddBoolean(Method->isVariadic());
     Hash.AddBoolean(Method->isSynthesizedAccessorStub());
     Hash.AddBoolean(Method->isDefined());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154460.537164.patch
Type: text/x-patch
Size: 2789 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230704/86341451/attachment.bin>