[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

Tue Jul 4 00:54:13 PDT 2023

cwalther added a comment.

Should I be worried about the build and test failures? At a glance, they look unrelated to my changes, so unless told otherwise I’m going to ignore them.

================
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:168
+
+  if (Triple.getVendor() != llvm::Triple::UnknownVendor)
+    return false;
----------------
jroelofs wrote:
> does this break your use cases re: having `indel` as the vendor? or will you have a downstream patch to exempt `indel` from this check?
No, `indel` is recognized as `Triple::UnknownVendor`, so this works for us. It would indeed stop working if `Indel` were added to `enum VendorType` (and the triple parsing functions), but I don’t expect that to happen.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154357/new/

https://reviews.llvm.org/D154357