[PATCH] D152021: [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect
Hubert Tong via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 3 20:40:45 PDT 2023
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.
LGTM with minor comment.
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:732-735
UseSeparateSections))
CmdArgs.push_back(
Args.MakeArgString(Twine(PluginOptPrefix) + "-data-sections=1"));
+ else if (Args.hasArg(options::OPT_fno_data_sections)) {
----------------
Coding standards suggest that braces be used consistently for each part of an if/else chain.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152021/new/
https://reviews.llvm.org/D152021
More information about the cfe-commits
mailing list