[PATCH] D135849: [llvm] Return canonical virtual path from `RedirectingFileSystem`

Mon Jul 3 11:55:27 PDT 2023

benlangmuir added a comment.

In D135849#4469347 <https://reviews.llvm.org/D135849#4469347>, @jansvoboda11 wrote:

> It'd be really nice to have DirectoryEntry::getDir() API, so that we can walk up the directory hierarchy while preserving the virtual/real distinction between directories in the overlay/on disk, never accidentally "bubbling up" into the overlay again. What's your take on that?

Can you say more about how you would do this and preserve the real/virtual distinction? Currently FileManager is just filling in the directory based on the parent path with a lookup to the VFS, so isn't it the same issue? Or did you mean we would keep more info?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135849/new/

https://reviews.llvm.org/D135849