[PATCH] D154335: [clang][tooling] Fix early termination when there are nested expansions

Mon Jul 3 07:26:07 PDT 2023

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.

================
Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:116
-
-    // Now: how do we adjust the previous/next bounds? Three cases:
-    // A) If they are also part of the same macro arg, we translate them too.
----------------
(no action needed)

we had extensive discussion of why this change is a no-op, and how to prove it, and what comments to leave.
However in the end I don't think such a comment is necessary, because the code makes sense in isolation, and equivalence-to-previous-version isn't very interesting!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154335/new/

https://reviews.llvm.org/D154335