[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 3 07:00:53 PDT 2023


aaron.ballman added a comment.

In D154334#4468404 <https://reviews.llvm.org/D154334#4468404>, @Fznamznon wrote:

> In D154334#4468158 <https://reviews.llvm.org/D154334#4468158>, @aaron.ballman wrote:
>
>> Thank you for this! LGTM. but can you also be sure to update this table: https://github.com/llvm/llvm-project/blob/main/clang/docs/LanguageExtensions.rst?plain=1#L1429
>
> Hmm, I have a feeling that the table is for features that have `__cpp_*` macros defined for them. The features I intended to fix are described by the same doc here - https://github.com/llvm/llvm-project/blob/29f4c398717184a019791ed52d1d0d69ed5dabb6/clang/docs/LanguageExtensions.rst?plain=1#L1071 .

Oh shoot, you're right, these don't have the typical feature testing macros from http://eel.is/c++draft/tab:cpp.predefined.ft ! Sorry for the noise, this is fine as-is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154334/new/

https://reviews.llvm.org/D154334



More information about the cfe-commits mailing list