[PATCH] D153776: [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

Mon Jul 3 02:56:55 PDT 2023

donat.nagy added a comment.

In D153776#4467627 <https://reviews.llvm.org/D153776#4467627>, @balazske wrote:

> The success/failure note tags are not added to all functions, `dup` is one of these, this means at `dup` no note tag is shown. A next patch can be made to add these messages to all functions. The other places look good, but CodeChecker is a bit tricky, you must select //*_stdclf_notetag_interesting_test_2// at the small arrow after the "found in:" text (upper right corner). The link is good but not that instance of the bug is displayed because only the note tags are different.

I think we should definitely add success/failure note tags to all functions where this checker can suddenly assume that "Oops, this failed". If this "Assuming that 'foo' fails" message is not there, it's a very natural reaction to search for some earlier note that would let the checker deduce that this function will fail here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153776/new/

https://reviews.llvm.org/D153776