[PATCH] D135849: [llvm] Return canonical virtual path from `RedirectingFileSystem`

Mon Jul 3 01:39:24 PDT 2023

jansvoboda11 added a comment.

In D135849#4464234 <https://reviews.llvm.org/D135849#4464234>, @benlangmuir wrote:

>> Just realized this most likely won't work if the case-insensitive VFS is specified with wrong spelling too, e.g. Fw.framework.
>
> Is this about the spelling in the VFS definition itself, or about the path being looked up?

Yes, spelling in the VFS definition itself.

> If it's the VFS definition maybe we can say that's a bug for whoever wrote the VFS? Ideally we could diagnose but I'm not sure we want to pay for a lot of calls to realpath.

You mean diagnosing whenever the spelling in the VFS definition differs from its realpath? How could we make that work with symlinks in place?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135849/new/

https://reviews.llvm.org/D135849