[PATCH] D154284: [C11] Correct global atomic pointer initialization from an integer constant
Eli Friedman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jul 2 11:17:54 PDT 2023
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
The testcase doesn't actually trigger the assertion... but I guess it still tests the output, so that's probably okay? Maybe add a case `static _Atomic(int *) glob_pointer_from_long = 0LL;` just to be sure.
Otherwise LGTM
(The "VarSize == CstSize" assertion has been catching a surprising number of cases of bad codegen; I'm happy I spent the time to add it.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154284/new/
https://reviews.llvm.org/D154284
More information about the cfe-commits
mailing list