[PATCH] D153510: [Clang][RISCV] Check type support for local variable declaration of RVV type
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jul 2 08:39:11 PDT 2023
aaron.ballman added a comment.
In D153510#4441541 <https://reviews.llvm.org/D153510#4441541>, @craig.topper wrote:
> @aaron.ballman The backend crashes at -O0 when scalable vector variables are declared because the stack frame code doesn't expect to see them when the vector extension isn't enabled.
That's a good reason to diagnose the declaration, but this makes the usage diagnostic very chatty -- if someone forgets to enable the extension, they'll get a diagnostic for each time they use the type and each time they declare something with the type, and there are likely to be more uses than there are declarations. No need to drown the user in repeated messages, so I think the diagnostic on usage should be disabled. WDYT?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153510/new/
https://reviews.llvm.org/D153510
More information about the cfe-commits
mailing list