[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

Sat Jul 1 22:35:29 PDT 2023

FreddyYe added a comment.

In D154209#4466304 <https://reviews.llvm.org/D154209#4466304>, @RKSimon wrote:

> LGTM - but it would be good to fix silvermont / westmere cases as well with suitable test coverage

Thanks review! After D151696 <https://reviews.llvm.org/D151696> landed, they can be both fixed and there will be more tests cover such missing like clang/test/Preprocessor/predefined-arch-macros.c. And about cpu_specific test coverage, I'll consider a way to refine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154209/new/

https://reviews.llvm.org/D154209