[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

Sat Jul 1 12:39:11 PDT 2023

JOE1994 added inline comments.

================
Comment at: clang/lib/CodeGen/CGExpr.cpp:3896
     llvm::Type *OrigBaseElemTy = Addr.getElementType();
-    Addr = Builder.CreateElementBitCast(Addr, Int8Ty);

----------------
barannikov88 wrote:
> jrtc27 wrote:
> > This one isn't a direct substitution, although appears to be refactoring the code to not need withElementType in the first place? Probably best to separate that change out from the very mechanical substitution.
> It will be difficult to find all such places later.
@jrtc27 Thank you for taking the time to review this revision.

This isn't a direct substitution.
In this revision overall, I did refactoring to get rid of unnecessary calls to `withElementType()` when possible.

Since these are relatively small & local refactorings, I'd prefer to keep them in this revision.
But if you're strongly against including such refactorings in this revision, I can separate them out to a new revision.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154285/new/

https://reviews.llvm.org/D154285