[PATCH] D153989: [compiler-rt] Move crt into builtins

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 30 17:11:22 PDT 2023


smeenai added a comment.

In D153989#4465907 <https://reviews.llvm.org/D153989#4465907>, @phosek wrote:

> In D153989#4465759 <https://reviews.llvm.org/D153989#4465759>, @smeenai wrote:
>
>> Sorry, it's been a week :D I assume that crt doesn't need the builtins to be available for its configure (the way the rest of compiler-rt does)? If so, this LGTM.
>
> Great question, I checked and crt doesn't need builtins, just Clang headers, same as builtins.

Cool, this does seem like the simplest and best way to go then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153989/new/

https://reviews.llvm.org/D153989



More information about the cfe-commits mailing list